Skip to content

fix(uri): don't glue * onto the authority in Display #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanmonstar merged 1 commit into from
Nov 10, 2026
Merged

fix(uri): don't glue * onto the authority in Display #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/uri/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,5 +257,6 @@ mod tests {
assert_eq!(uri.scheme(), Some(&Scheme::HTTPS));
assert_eq!(uri.host(), Some("example.com"));
assert_eq!(uri.path(), "*");
assert_eq!(uri.to_string(), "https://example.com");
}
}
6 changes: 5 additions & 1 deletion src/uri/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,11 @@ impl fmt::Display for Uri {
f.write_str(authority.as_str())?;
}

f.write_str(self.path())?;
// RFC 9112 3.2.4: the absolute-form of an asterisk-form target has an
// empty path. Writing the `*` would make it part of the authority.
if self.authority().is_none() || self.path() != "*" {
f.write_str(self.path())?;
}

if let Some(query) = self.query() {
f.write_str("?")?;
Expand Down
Loading