[0.2.x] introduce TryFrom impls for path, scheme, uri and authority #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I’m not one with the final authority on the matter, but I’d be happy to merge this in and pick up the remaining work of removing |
seanmonstar
approved these changes
Jul 24, 2019
seanmonstar
pushed a commit
that referenced
this pull request
Nov 26, 2019
seanmonstar
pushed a commit
that referenced
this pull request
Nov 26, 2019
seanmonstar
pushed a commit
that referenced
this pull request
Nov 26, 2019
seanmonstar
pushed a commit
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of #308 on the 0.2.x branch
TryFrom, however doesn't removeHttpTryFromor change other bits in any way, to keep the PR small and unblock others to continue this work.HttpTryFromcompletely if so required./cc @seanmonstar @davidbarsky