fix: do not assign capacity for pending streams #860
+82
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
force-pushed
the
no-capacity-for-unopened-streams
branch
2 times, most recently
from
9b330f4 to
34de0d6
Compare
`Prioritize::send_data` has a check to prevent assigning capacity to streams that are not yet open. Assigning flow control window to pending streams could starve already open streams. This change adds a similar check to `Prioritize::reserve_capacity`. Test `capacity_not_assigned_to_unopened_streams` in `flow_control.rs` demonstrates the fix. A number of other tests must be changed because they were assuming that pending streams immediately received connection capacity. This may be related to hyperium#853.
benjaminp
force-pushed
the
no-capacity-for-unopened-streams
branch
from
34de0d6 to
98d1c12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prioritize::send_datahas a check to prevent assigning capacity to streams that are not yet open. Assigning flow control window to pending streams could starve already open streams.This change adds a similar check to
Prioritize::reserve_capacity.Test
capacity_not_assigned_to_unopened_streamsinflow_control.rsdemonstrates the fix.A number of other tests must be changed because they were assuming that pending streams immediately received connection capacity.
This may be related to #853.