Update to std::future

[95th]

Closes #385

[95th]

For some reason, CI is using old version of Rust Nightly. Multiple lifetime issue has been resolved a month now. @seanmonstar How do I make it use latest Nightly?

[seanmonstar]

I'm on vacation for a couple weeks with no computer and spotty internet. If no one else looks while I'm gone, I'll take a look when I get back.

Ping @carllerche @sgrif

[carllerche]

And @sgrif is sick. I def want to pull in one of the seans...

[95th]

@carllerche Okay.. Meanwhile I'll finish up what's remaining. Current status:

Works:

• Code builds
• Internal h2 crate tests pass
• h2spec passes
• h2-test passes
• doc tests pass
• h2-fuzz compiles

In progress:

• A few h2-tests fail.
  Failing mostly in [assert_client_handshake]
• doc tests needs to be updated - I am thinking of doing it in a separate PR.
• h2-fuzz - needs to updated - will update it after fixing the h2-tests
• h2-fuzz needs to be tested - honggfuzz don't work on WSL and Travis is acting up. So can't really test.

cc @LucioFranco

[95th]

Since integrated CI doesnt use correct rust version, here is a build run against my fork:

https://travis-ci.org/95th/h2/builds/567710136

[95th]

@carllerche
Most of the failing tests have similar errors:

expected SETTINGS; actual=Headers { stream_id: StreamId(1), flags: (0x5: END_HEADERS | END_STREAM) }
expected SETTINGS; actual=Headers { stream_id: StreamId(1), flags: (0x4: END_HEADERS) }

The error comes in assert_client_handshake when trying to assert settings ACK.

Any ideas?

cc @LucioFranco @sgrif

[sgrif]

Is there any way for you to break this up into smaller pieces? As I've been working through this my plan was to start with just h2-support and the tests, since those can be changed without touching the main crate, while the inverse is not true. 6k lines changed is a lot to review at once

[95th]

Looks like my own PR rust-lang/rust#63514 has come back to bite me

[95th]

@sgrif I rewrote commit history where each commit updates one area. Is that sufficient or do you want me to open separate PRs? BTW I have already updated h2-support, h2-tests, h2-fuzz also.

[seanmonstar]

This is an awesome amount of work, thank you! Left some comments inline.

[seanmonstar]

Excellent work!

[LucioFranco]

@95th awesome job! 🎉