-
Notifications
You must be signed in to change notification settings - Fork 85
App server #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
App server #118
Conversation
@ashconnell @DevStarlight @saori-eth would appreciate thoughts on the general idea and UX flow, is this on the right path? |
Generally, I like the path. Few things I noticed:
|
dang ok, gonna look at this soon, hyped! |
a9796ca
to
23e8024
Compare
I've removed all app server code from here, leaving only the changes needed on the client in order for it to be able to connect to servers. I have created another repo https://github.com/peezy/hyperfy-app-server (basically just to hide few thousand lines of code from ai in the future) also made this https://github.com/peezy/threejs-vibe-coding-starter-kit to demonstrate how servers can be used. i feel like both of these repos should belong to hyperfy org tho |
Peezy said this was ready to be looked over @ashconnell. I've tested it extensively at this point and everything works pretty well. There are things that can be improved but over all i think good start. Let us know if there's anything you want changed or are confused about please. |
Ok sounds good, will check this out tomorrow and report back |
@peezy i ran into some weird syncing issues where sometimes it would sync up but not others, and i think if you duplicate an app then only one would update etc. will keep playing around with it and have a look over the code. |
if you duplicate and unlink they shouldn't update, right? since its now a different blueprint. |
woah |
App server
as per #110 (comment):
my proposal is to have a
PUBLIC_DEV_SERVER
flag that, when active, adds a new system to the client that attempts a connection with an app server onlocalhost:8080
(port can be changed). this system:the app server itself is a small class that anyone can hook up handlers in order to create their own custom functionality for their use case (typescript? code splitting?). if we run
node tools/server.js
(which we should hook up tonpx hyperfy app-server
imo) it runs a basic server with hot reloading.the idea of separating a thin server from the handlers enables people to build their own custom servers which could include code splitting, typescript, anything they need.
keeping the app server totally separate from the client but still requiring the auth token enables apps with custom deploy pipelines (with the node client) but still tied to a specific user (which might be handy if we ever add audit changes ("last change by: peezy")
what needs to be agreed upon for merging:
vibe coding starter kit
repository with a server, some docs on scripting and instructions for claude code