-
Notifications
You must be signed in to change notification settings - Fork 261
feat: Add charts API #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add charts API #811
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fe1f0bd
to
4529973
Compare
4529973
to
18b725a
Compare
Ref: HDX-1239
18b725a
to
64c8378
Compare
expect(Number(response.body.data[0]['series_0.data'])).toEqual(1); | ||
}); | ||
|
||
it('should handle lucene query errors gracefully', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a corresponding test to handle sql errors - e.g. what does it return when I give it a non-sql where clause when whereLanguage == 'sql'
?
Testing Notes:
It was easiest for me to go to the UI, create a new chart and grab the sourceid and start/end timestamps from the URL, plug it in and profit.
Note: It was apparent to me that we will need to provide at least GET support for sources, otherwise that ID is not easily obtained.
Ref: HDX-1651