-
Notifications
You must be signed in to change notification settings - Fork 328
Refactor: Remove bootstrap, adopt semantic tokens, and improve Mantine UI usage #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Updated button colors and variants across ClickhousePage, DBChartPage, and DBSearchPage for better visual consistency. - Refined ActionIcon styles in ThemeWrapper to enhance default and subtle variants. - Adjusted background and border colors in various components to align with new semantic color variables. - Replaced hardcoded colors with CSS variables for better theme management in stylesheets. - Removed deprecated design tokens and introduced new semantic color definitions for dark and light modes. - Added custom utility classes for layout and spacing to supplement Bootstrap utilities. - Cleaned up unused styles and variables to streamline the codebase.
- Added muted variant styles for Card and Paper components in ThemeWrapper. - Removed color prop from multiple Text and Button components to use default theme colors. - Updated background colors in various components to use new color variables. - Refactored styles in Table and LogTable modules for consistency with new color scheme. - Removed unused color classes and variables to streamline styles. - Enhanced hover effects for buttons and text elements for better UX.
…across components
…variables; update styles for consistency across the application; enhance accessibility by adjusting text properties; modify button variants for improved UI/UX; streamline form elements and layout for better responsiveness; clean up unused imports and redundant code; ensure uniformity in text sizes and colors throughout the application.
…lean up related code; replace NavHoverDropdown with Mantine's Button component; update styles in SessionSidePanel and various SCSS files for consistency and improved theming; delete obsolete variables.scss file.
…t; update related modal handling and styling for consistency
…ructure and improve readability; adjust Badge component usage in AppNavLink for better consistency; update ThemeWrapper to remove default radius for enhanced theming flexibility
…cy; enhance color usage across components; streamline styles for improved theming and accessibility
…d colors; adjust height for improved styling consistency; enhance BreadcrumbNavigation text color for better visibility; implement custom cursor style for table column resizing; modify semantic colors for improved theming and accessibility.
… and maintainability
…with custom implementations for improved consistency and maintainability
🦋 Changeset detectedLatest commit: ecab514 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: Bootstrap Removal & Mantine Migration✅ Overall AssessmentThis is a well-structured refactor that successfully removes Bootstrap dependencies and migrates to Mantine UI with semantic design tokens. The approach is solid and aligns with modern React/Next.js best practices. Critical IssuesNone found - the PR appears safe to merge from a code quality perspective. Important Observations✅ Strengths:
Testing Recommendations
VerdictApproved - No blocking issues. The minor items noted above can be addressed in follow-up PRs or confirmed as intentional. |
E2E Test Results✅ All tests passed • 39 passed • 3 skipped • 399s
|
…r variable; remove unused color classes for improved clarity and maintainability
… variables for background and border styles; enhance link color based on active state for improved theming and consistency
…aintainability across multiple components
…e bootstrap utilities documentation for clarity
|
Just leaving a different comment since I started trying to split it into smaller PRs. So, the options are:
|
…tion style: add hover effect for success text utility class
|
FWIW: I like the idea of smaller PRs, but for a change this impactful, it's best to rip the bandaid off once vs. slowly. |
|
Whoops, I missed the edited comment, sorry @elizabetdev. Ripping the band-aid off is OK with me 👍 |
|
@teeohhem I updated the AppNav component to bring it closer to the previous version. The icons on this PR are from Tabler, and a few small UI details were left intentionally (e.g., icon highlight behavior and the beta badge aligned to the right). The beta badge is also using Mantine’s default styling with no overrides, so the text defaults to white. The nav now uses only mantine colors.
|
teeohhem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!



Description
This PR improves the overall design system consistency, theming capabilities, and maintainability of the project by removing Bootstrap dependencies and enhancing Mantine UI usage.
It also serves as step one in preparing the codebase for the future introduction of Click-UI, which will further streamline and unify component usage across the application.
Key Changes
Motivation
Previously, the dark mode was achieved through a global CSS filter, such as:
While this approach provided a quick inversion effect, it had several drawbacks:
By moving to a token-based theme system powered by Mantine, we ensure predictable, maintainable, and accessible theming across all components.
Testing Notes