Remove type=global from /spaces api call #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Passing the
type=global
query param in thespaces
API call preventsmd2conf
from being used withknowledge_base
spaces.Note
I did consider allowing the user to pass in the type via a
--space-type
flag with a default toglobal
but my Python isn't fantastic. That feels like it would be a significant improvement over this PR but may not be necessary.Contributing
I've read
CONTRIBUTING.md
and rancheck.sh
prior to raising the PR.