Skip to content

Commit

Permalink
fix: unit test was broken since kubernetes-sigs#159 and also from kub…
Browse files Browse the repository at this point in the history
…ernetes-sigs#240 (building

policies)

Signed-off-by: Hunter Gregory <[email protected]>
  • Loading branch information
huntergregory committed Aug 8, 2024
1 parent 90df795 commit ddceefc
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions cmd/policy-assistant/pkg/matcher/builder_tests.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func RunBuilderTests() {
ingress, egress := BuildTarget(netpol.AllowNoIngress)

Expect(ingress).ToNot(BeNil())
Expect(ingress.Peers).To(BeNil())
Expect(ingress.Peers).To(Equal([]PeerMatcher{&NoMatcher{}}))

Expect(egress).To(BeNil())
})
Expand All @@ -37,7 +37,7 @@ func RunBuilderTests() {
ingress, egress := BuildTarget(netpol.AllowNoEgress)

Expect(egress).ToNot(BeNil())
Expect(egress.Peers).To(BeNil())
Expect(egress.Peers).To(Equal([]PeerMatcher{&NoMatcher{}}))

Expect(ingress).To(BeNil())
})
Expand All @@ -46,10 +46,10 @@ func RunBuilderTests() {
ingress, egress := BuildTarget(netpol.AllowNoIngressAllowNoEgress)

Expect(egress).ToNot(BeNil())
Expect(egress.Peers).To(BeNil())
Expect(egress.Peers).To(Equal([]PeerMatcher{&NoMatcher{}}))

Expect(ingress).ToNot(BeNil())
Expect(ingress.Peers).To(BeNil())
Expect(ingress.Peers).To(Equal([]PeerMatcher{&NoMatcher{}}))
})
})

Expand All @@ -75,7 +75,7 @@ func RunBuilderTests() {
ingress, egress := BuildTarget(netpol.AllowNoIngress_EmptyIngress)

Expect(ingress).ToNot(BeNil())
Expect(ingress.Peers).To(BeNil())
Expect(ingress.Peers).To(Equal([]PeerMatcher{&NoMatcher{}}))

Expect(egress).To(BeNil())
})
Expand All @@ -84,7 +84,7 @@ func RunBuilderTests() {
ingress, egress := BuildTarget(netpol.AllowNoEgress_EmptyEgress)

Expect(egress).ToNot(BeNil())
Expect(egress.Peers).To(BeNil())
Expect(egress.Peers).To(Equal([]PeerMatcher{&NoMatcher{}}))

Expect(ingress).To(BeNil())
})
Expand All @@ -93,10 +93,10 @@ func RunBuilderTests() {
ingress, egress := BuildTarget(netpol.AllowNoIngressAllowNoEgress_EmptyEgressEmptyIngress)

Expect(egress).ToNot(BeNil())
Expect(egress.Peers).To(BeNil())
Expect(egress.Peers).To(Equal([]PeerMatcher{&NoMatcher{}}))

Expect(ingress).ToNot(BeNil())
Expect(ingress.Peers).To(BeNil())
Expect(ingress.Peers).To(Equal([]PeerMatcher{&NoMatcher{}}))
})
})

Expand Down Expand Up @@ -128,12 +128,12 @@ func RunBuilderTests() {
Describe("PeerMatcher from slice of ingress/egress rules", func() {
It("allows no ingress from an empty slice of ingress rules", func() {
peers := BuildIngressMatcher("abc", []networkingv1.NetworkPolicyIngressRule{})
Expect(peers).To(BeNil())
Expect(peers).To(Equal([]PeerMatcher{&NoMatcher{}}))
})

It("allows no egress from an empty slice of egress rules", func() {
peers := BuildEgressMatcher("abc", []networkingv1.NetworkPolicyEgressRule{})
Expect(peers).To(BeNil())
Expect(peers).To(Equal([]PeerMatcher{&NoMatcher{}}))
})

It("allows all ingress from an ingress containing a single empty rule", func() {
Expand Down

0 comments on commit ddceefc

Please sign in to comment.