feat(combobox): add autoHighlight prop#2079
Draft
maxffarrell wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 7594ff9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
maxffarrell
force-pushed
the
codex/combobox-auto-highlight
branch
from
f5af619 to
0026691
Compare
maxffarrell
force-pushed
the
codex/combobox-auto-highlight
branch
from
0026691 to
b4c923f
Compare
maxffarrell
force-pushed
the
codex/combobox-auto-highlight
branch
from
b4c923f to
8d19314
Compare
maxffarrell
force-pushed
the
codex/combobox-auto-highlight
branch
from
8d19314 to
7594ff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
autoHighlightprop toCombobox.Rootso the first matching item can be highlighted automatically after the user filters the list.This follows the public Base UI combobox surface that shadcn/ui consumes:
autoHighlight?: boolean. Base UI internally has a stronger'always'mode, but its publicCombobox.Rootprop exposed to shadcn/ui is boolean, wheretruehighlights after input/filtering rather than on initial open.Changes
autoHighlight?: booleanto combobox root props.autoHighlightis enabled for comboboxes.Validation
pnpm -F bits-ui buildpnpm -F bits-ui checkpnpm exec prettier --check .changeset/quiet-comboboxes-highlight.md docs/content/components/combobox.md docs/src/lib/content/api-reference/combobox.api.ts packages/bits-ui/src/lib/bits/combobox/components/combobox.svelte packages/bits-ui/src/lib/bits/combobox/types.ts packages/bits-ui/src/lib/bits/select/components/select.svelte packages/bits-ui/src/lib/bits/select/select.svelte.ts tests/src/tests/combobox/combobox.browser.test.tsNote: focused
pnpm -F tests test:browser --browser chromium src/tests/combobox/combobox.browser.test.tsstarted successfully after building the package, but this local Node 26/Vitest browser setup OOMed before completion, including when narrowed to-t auto-highlight.