Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align author image display size & actual size #284

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

cyrilmottier
Copy link
Contributor

@cyrilmottier cyrilmottier commented Feb 17, 2025

What problem does this PR solve?

Cleanup author image handling and use <img /> scrset attribute to better expose display density-compliant images. Being the only image really showed in the entire theme, it deserves polish.

Is this PR adding a new feature?

No

Is this PR related to any issue or discussion?

No

PR Checklist

  • I have verified that the code works as described/as intended.
  • This change adds a social icon which has a permissive license to use it.
  • This change does not include any external library/resources.
  • This change does not include any unrelated scripts (e.g. bash and python scripts).
  • I have enabled maintainer edits for this PR.

Use <img /> secret attribute to better expose display density-compliant images. Being the only image really showed in the entire theme, it deserves polish.
Copy link

netlify bot commented Feb 17, 2025

Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit 6a77b75
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/67b2e700e8df4c0008baa3a9
😎 Deploy Preview https://deploy-preview-284--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cyrilmottier for the fix.

@hugo-sid hugo-sid merged commit a919504 into hugo-sid:main Mar 3, 2025
8 checks passed
viazure pushed a commit to viazure/hugo-blog-awesome that referenced this pull request Mar 5, 2025
* fix: align image display size & actual size

* fix: use appropriate size

* fix: deal with displays densities

Use <img /> secret attribute to better expose display density-compliant images. Being the only image really showed in the entire theme, it deserves polish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants