feat: gemini capsule based themes, lagrange-like#30
Merged
Conversation
By copy-and-pasting from Lagrange codebase I was somewhat able to reproduce similar styling of gemini pages. A lot of TODOs still.
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Malformed `=>` lines with no URL currently generate a link entry with an empty target.
At least some context will be there!
`canGoBack()` and `canGoForward()` currently read shared navigation state outside the lock used for updates, which can cause inconsistent back/forward functionality
Allows me to just reuse this thing in 2 places in codebase
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
`cachedCertificates` is mutated and read from multiple paths without synchronization
In theory, it might try to reload perfectly valid empty gemini pages
Owner
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By copy-and-pasting from Lagrange codebase I was somewhat able to reproduce similar styling of gemini pages. A lot of TODOs still.
Also, had to cherry-pick this because I forgot to change branch again.
Summary by CodeRabbit
New Features
Performance
UI/UX
Localization