Rename data processing class names to reflect functionality #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanses
reviewed
Feb 18, 2025
| @@ -57,8 +57,10 @@ impl CASDataAggregator { | |||
| /// Manages the translation of files between the | |||
| /// MerkleDB / pointer file format and the materialized version. | |||
| /// | |||
| /// This class handles the clean and smudge options. | |||
| pub struct PointerFileTranslator { | |||
| /// This class handles the clean and smudge options. It's meant to be a single atomic session | |||
There was a problem hiding this comment.
The upload operation is "session"-based which has clear close session definition (finalize_cleaning) but download is not, each call can succeed or fail independently without interfering others.
There was a problem hiding this comment.
Ah, fair. I will clarify the comment...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the following to more clearly reflect the current functionality:
The mental model is that a call to download_files or upload_files defines a session, where a session may translate multiple files must fully complete, including completing any remote operations, before returning. This renaming makes this it clearer where the functionality of different parts of this model live.