-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding request_id to logs from CAS requests #173
Conversation
jgodlew
commented
Feb 14, 2025
- Add debug log to http client whenever we receive a response from CAS, logging the request_id and status code.
- Add request_id to error logs when a response from CAS fails
- Refactor logic to process http response result into a helper trait/fn for consistency across CAS apis.
Example error message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you also help refactor similar places in HttpShardClient?
|