Make CasObject serde::Serializable #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znation
force-pushed
the
zn/pr-serialize-casobject
branch
from
2d82100 to
29e5ff2
Compare
assafvayner
approved these changes
Feb 14, 2025
seanses
reviewed
Feb 14, 2025
| @@ -19,7 +20,7 @@ pub(crate) const CAS_OBJECT_FORMAT_IDENT: CasObjectIdent = [b'X', b'E', b'T', b' | |||
| pub(crate) const CAS_OBJECT_FORMAT_VERSION: u8 = 0; | |||
| const CAS_OBJECT_INFO_DEFAULT_LENGTH: u32 = 60; | |||
|
|
|||
| #[derive(Clone, PartialEq, Eq, Debug)] | |||
| #[derive(Clone, PartialEq, Eq, Debug, Serialize)] | |||
There was a problem hiding this comment.
Just a thought, you may want to #[serde(skip)] the _buffer: [u8; 16] field.
seanses
approved these changes
Feb 14, 2025
sirahd
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title -- should be self-explanatory.