Consistency regarding relative imports #4498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR converts absolute imports to relative imports across multiple files in the TRL library. The changes improve import consistency by using relative paths instead of absolute trl.* imports.
Key changes:
- Standardizes import style from absolute to relative imports
- Maintains proper relative path depth based on module location
- Consolidates multi-line imports in one file to single-line format
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| trl/trainer/nash_md_config.py | Changed import from trl.trainer.online_dpo_config to relative import .online_dpo_config |
| trl/rewards/accuracy_rewards.py | Changed import from trl.import_utils to relative import ..import_utils |
| trl/mergekit_utils.py | Changed import from trl.import_utils to relative import .import_utils |
| trl/experimental/gspo_token/grpo_trainer.py | Changed import from trl to relative import ...trainer.grpo_trainer and removed blank line |
| trl/experimental/grpo_with_replay_buffer/grpo_with_replay_buffer_trainer.py | Changed multi-line imports from trl.data_utils and trl.trainer to single-line relative imports using ... |
| trl/experimental/grpo_with_replay_buffer/grpo_with_replay_buffer_config.py | Changed import from trl.trainer.grpo_config to relative import ...trainer.grpo_config |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just improve codebase consistency wrt relative imports