Move RLOOTrainer to trl.experimental.rloo #4484
Open
+2,235
−2,135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
- Update dataset_formats.md: RLOOTrainer → experimental.rloo.RLOOTrainer - Update example_overview.md: RLOOTrainer → experimental.rloo.RLOOTrainer - Update rloo_trainer.md: all trainer references to experimental path - Move test file to tests/experimental/test_rloo_trainer.py - Update test imports to use parent directory reference Follows pattern from XPO PR #4485
Remove implementation code that was incorrectly merged into the deprecation wrapper. The wrapper should only contain the deprecation warning and delegate to the experimental module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates RLOOTrainer to the experimental module as part of the TRL V1 refactoring effort.
Changes
Testing
Contributes to #4374
Fixes #4468