Skip to content

Conversation

@i3hz
Copy link
Contributor

@i3hz i3hz commented Oct 21, 2025

What does this PR do?

Fixes the issue where if you save the config and load it again it would return the incorrect model_type .
Minor fix in getattribute method of the config class for both models .

Fixes # 41746

Before submitting

Who can review?

@zucchini-nlp
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Qubitium
Copy link
Contributor

@ZX-ModelCloud Please verify this.

@ZX-ModelCloud
Copy link
Contributor

ISSUE#41746 Fixed in this PR.

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. Can we add a test in

, reproducing the original bug to make sure it is fixed and avoid regressions?

@i3hz
Copy link
Contributor Author

i3hz commented Oct 21, 2025

Do I add it in the existing test_text_config function or make a new one?

@zucchini-nlp
Copy link
Member

Let's add in existing, it's the same regression being tested

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: qwen2_5_vl, qwen2_vl

@i3hz
Copy link
Contributor Author

i3hz commented Oct 21, 2025

I've added the required tests

@i3hz i3hz requested a review from zucchini-nlp October 21, 2025 10:35
Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zucchini-nlp zucchini-nlp enabled auto-merge (squash) October 21, 2025 10:46
@zucchini-nlp zucchini-nlp merged commit ede7976 into huggingface:main Oct 21, 2025
17 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@i3hz i3hz deleted the qwen2 branch October 21, 2025 12:29
ngazagna-qc pushed a commit to ngazagna-qc/transformers that referenced this pull request Oct 23, 2025
…aved and loaded again (huggingface#41758)

* fixed incorrect model_type for qwen2vl and qwen2.5vl

* added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants