-
Notifications
You must be signed in to change notification settings - Fork 30.9k
Fixed incorrect model_type for qwen2vl and qwen2.5vl when config is saved and loaded again #41758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ZX-ModelCloud Please verify this. |
|
ISSUE#41746 Fixed in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me. Can we add a test in
| def test_text_config(self): |
|
Do I add it in the existing test_text_config function or make a new one? |
|
Let's add in existing, it's the same regression being tested |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen2_5_vl, qwen2_vl |
|
I've added the required tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…aved and loaded again (huggingface#41758) * fixed incorrect model_type for qwen2vl and qwen2.5vl * added tests
What does this PR do?
Fixes the issue where if you save the config and load it again it would return the incorrect model_type .
Minor fix in getattribute method of the config class for both models .
Fixes # 41746
Before submitting
Pull Request section?
to it if that's the case. - When Qwen2VLConfig is saved and loaded again, an incorrect model_type will be obtained #41746
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@zucchini-nlp
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.