fix: ImageTextToTextPipeline handles user-defined generation_config #39374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assed to the pipeline
|
Makes sense - cc @zucchini-nlp, I assume there are no issues with passing |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
rjgleaton
pushed a commit
to rjgleaton/transformers
that referenced
this pull request
Jul 17, 2025
…uggingface#39374) fix: ImageTextToTextPipeline handles user-defined generation_config passed to the pipeline Co-authored-by: Raushan Turganbay <[email protected]>
zucchini-nlp
added a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 22, 2025
…uggingface#39374) fix: ImageTextToTextPipeline handles user-defined generation_config passed to the pipeline Co-authored-by: Raushan Turganbay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allows an ImageTextToTextPipeline object to handle a user-defined generation_config passed to the pipeline, the same way a TextGenerationPipeline object does. Currently, it ignores these generation_config parameters set on pipeline object initialization, causing unexpected text generation behavior.
@Rocketknight1