Avoid build crashes when torch.version.xpu doesn't exist and fix Llama4 processor tests #37346
Conversation
|
In future we may want to refactor this to use |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Rocketknight1
changed the title
|
Adding the Llama4 processor test fixes to this PR because they're making the CI red, so I can't merge without them. cc @ydshieh @ArthurZucker @zucchini-nlp |
There was a problem hiding this comment.
Thanks! The test_image_chat_template_accepts_processing_kwargs thing will be fixed by #37275, so we can skip for a while, not big deal :)
|
One more error here, this time in |
|
@Rocketknight1 seems to be that we try to load slow processor while fast was saved. I am not sure if we support loading this way, can check real quick |
|
@zucchini-nlp just going to add another skip for now to make the CI clear! |
|
Oh wait, slow processor doesn't even exist. Makes sense to skip, should not be tested, thanks! We'll make this test more generalizable, in subsequent PRs :) |
|
Tests green, merging to clear the CI! |
…a4 processor tests (huggingface#37346) * Avoid build crashes when torch.version.xpu doesn't exist * Trigger tests * Fix image token and skip inappropriate test * Remove ignore_errors=True * Add another skip
|
thx, get_attr is safer, will follow up on a more safter way to check. |
…a4 processor tests (huggingface#37346) * Avoid build crashes when torch.version.xpu doesn't exist * Trigger tests * Fix image token and skip inappropriate test * Remove ignore_errors=True * Add another skip
…a4 processor tests (huggingface#37346) * Avoid build crashes when torch.version.xpu doesn't exist * Trigger tests * Fix image token and skip inappropriate test * Remove ignore_errors=True * Add another skip
Quick update to #37126 which breaks on my local machine because
torch.version.xpudoesn't exist. I'm not sure which versions that exists for and which doesn't, but we can just usegetattr()to avoid crashes in those cases either way.