Deprecate modeling_utils.py classes #37298
Open
+1,797
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run-slow: gpt2, xlm, xlnet, electra |
|
This comment contains run-slow, running the specified jobs: This comment contains run-slow, running the specified jobs: models: ['models/gpt2', 'models/xlm', 'models/xlnet'] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
cc @Rocketknight1 when you have bandwidth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Classes such as
PoolerStartLogits,PoolerEndLogits,PoolerAnswerClass,SQuADHead, andSequenceSummaryare:modeling_utils.py, which is somewhat against the main repository philosophy of having classes defined within dedicated modeling filesFollowing the above, I have transferred them to the corresponding modeling files and deprecated those in
modeling_utils.py. This should uncluttermodeling_utils.pyand make it easier to remove those classes when models are going to be deprecated.