Skip to content

Stream reading a Response object may not be available while a progress callback is specified #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stream reading a Response object may not be available while a progress callback is specified #1281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/utils/hub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,12 +578,17 @@ export async function getModelFile(path_or_repo_id, filename, fatal = true, opti
buffer = new Uint8Array(await response.arrayBuffer());

} else if (
cacheHit // The item is being read from the cache
&&
typeof navigator !== 'undefined' && /firefox/i.test(navigator.userAgent) // We are in Firefox
(
// Due to bug in Firefox, we cannot display progress when loading from cache.
// Fortunately, since this should be instantaneous, this should not impact users too much.
cacheHit // The item is being read from the cache
&&
typeof navigator !== 'undefined' && /firefox/i.test(navigator.userAgent) // We are in Firefox
) || (
// The `body` property may not be available on a Response object to do streaming, e.g., when using a fetch polyfill
typeof response.body === 'undefined'
)
) {
// Due to bug in Firefox, we cannot display progress when loading from cache.
// Fortunately, since this should be instantaneous, this should not impact users too much.
buffer = new Uint8Array(await response.arrayBuffer());

// For completeness, we still fire the final progress callback
Expand Down