Pr 2954 ci branch #3006
Open
Pr 2954 ci branch #3006
+60
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary to keep compatibility with openai. The usage of tgi with openai compatible libraries for function calling was broken.
The streaming API for tool calling now starts when the name is parsed and then send arguments as token are generated and stops properly.
…ction definition type
|
Hi @drbh Thanks for moving forward with my PR ! However, there's something I'm not understanding. Your changes seem to remove my fixes related to streaming. I haven't had time to test the branch but by reading your changes it seems the tool calls will still be impossible to use with streaming using an open ai client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reopens #2954 and adds some small changes to rely on serde where possible. Thank you @Trofleb for the changes!
This PR aligns the tool calling output to return an array of tool calls as well as serialize the tool arguments as a JSON string.
Important
This PR contains breaking changes and aligns the tool choice output to match openai