Skip to content

fix Qwen VL break in intel platform #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix Qwen VL break in intel platform #3002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57385c5
fix Qwen VL break in intel platform
sywangyi Feb 10, 2025
9d7f257
could use PositionRotaryEmbedding impl so rocm and ipex could all work
sywangyi Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions server/text_generation_server/layers/rotary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,22 +570,6 @@ def __init__(self, inv_freq: torch.Tensor, scaling_factor: float, sections: list
.to(inv_freq.device)
)

def forward(
self,
query: torch.Tensor,
key: torch.Tensor,
cos: torch.Tensor,
sin: torch.Tensor,
):
# rotate half the sequence length
rot = cos.shape[-1] // 2
q2 = torch.cat([-query[..., rot:], query[..., :rot]], dim=-1)
k2 = torch.cat([-key[..., rot:], key[..., :rot]], dim=-1)

# apply the rotation
rotary_emb.apply_rotary(query, q2, cos, sin, query, q2, True)
rotary_emb.apply_rotary(key, k2, cos, sin, key, k2, True)

def _update_cos_sin_cache(
self, dtype: torch.dtype, device: torch.device, seqlen: int
):
Expand Down Expand Up @@ -614,7 +598,4 @@ def get_cos_sin(

cos = self._cos_cached[position_ids].gather(1, self._sections[:slen])
sin = self._sin_cached[position_ids].gather(1, self._sections[:slen])

cos = torch.cat([cos, cos], dim=-1)
sin = torch.cat([sin, sin], dim=-1)
return cos, sin
Loading