Skip to content

Conversation

@mattt
Copy link
Collaborator

@mattt mattt commented Dec 5, 2025

This PR updates HubApi to use HubClient from the swift-huggingface package.

@ronaldmannak
Copy link

Hey @mattt It looks like there's still a local path in Package.swift

.package(path: "../swift-huggingface")

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Haven't had a chance to test it yet.

Do you think we should write a transition guide of some sort? Happy to help with that.

dependencies: [
.package(url: "https://github.com/huggingface/swift-jinja.git", from: "2.0.0")
.package(url: "https://github.com/huggingface/swift-jinja.git", from: "2.0.0"),
.package(path: "../swift-huggingface"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.package(path: "../swift-huggingface"),
.package(url: "https://github.com/huggingface/swift-huggingface", from: "0.4.1"),

As @ronaldmannak mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants