Use filetype for better type detection in GradIO #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysradium
changed the title
sysradium
force-pushed
the
gradio-file-texten-detection
branch
from
4a7cfcb to
e8f20f6
Compare
sysradium
changed the title
sysradium
force-pushed
the
gradio-file-texten-detection
branch
from
e8f20f6 to
2349ff7
Compare
|
@sysradium feel free to continue work on this PR now that #342 is merged! |
|
Thanks. I will introduce tests as well. |
sysradium
force-pushed
the
gradio-file-texten-detection
branch
6 times, most recently
from
532d4fa to
234c5f6
Compare
|
@aymeric-roucher added tests. |
|
|
||
| def tearDown(self): |
There was a problem hiding this comment.
Why remove this method?
There was a problem hiding this comment.
Because it is no-longer needed. Each test receives its own file_upload_dir, tmpdir fixture which are automatically wiped out by pytest itself.
| @@ -20,7 +20,7 @@ dependencies = [ | |||
| "pillow>=11.0.0", | |||
| "markdownify>=0.14.1", | |||
| "duckduckgo-search>=6.3.7", | |||
| "python-dotenv" | |||
| "python-magic>=0.4.27,<0.5.0", | |||
There was a problem hiding this comment.
Is adding this import really necessary?
There was a problem hiding this comment.
It is needed if we want to use python-magic for filetype detection. If we don't want then the most of the pr is pointless.
sysradium
force-pushed
the
gradio-file-texten-detection
branch
from
38a7643 to
4e8c077
Compare
sysradium
force-pushed
the
gradio-file-texten-detection
branch
from
4e8c077 to
5d53b81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #566