Skip to content

Add translation guidelines and issue template #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add translation guidelines and issue template #1811

wants to merge 6 commits into from
+135 −16

Conversation

@suryabdev
Copy link
Contributor

More details discussed in #1810

This PR adds guidelines to translate the documentation and a corresponding github issue template

@suryabdev suryabdev mentioned this pull request Oct 12, 2025
Open
aymeric-roucher
aymeric-roucher approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@aymeric-roucher aymeric-roucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that seems very clear!

@suryabdev
Copy link
Contributor Author

PR quality check failed with errors unrelated to this PR. Those should be fixed in #1809. Merged this branch with main
@aymeric-roucher Thanks for the review, Please re-trigger the checks when you are free

albertvillanova
albertvillanova reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments/suggestions/questions below.

docs/README.md

### Translating

When translating, refer to the guide at [./TRANSLATING.md](https://github.com/huggingface/smolagents/blob/main/docs/TRANSLATING.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should locate the TRANSLATING.md file at the root of the repo, what do you think?

Copy link
Contributor Author

@suryabdev suryabdev Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the file location from the transformers repo (/docs)
One reason for them placing it in the docs folder could be that all documentation and instructions for contributing to the docs are located there. (e.g., /docs/README.md). So it is an intuitive location, but I don't have any strong opinions. I’m fine with moving it to the root of the repository if that’s what you prefer.

@suryabdev
Copy link
Contributor Author

suryabdev commented Oct 16, 2025 •
edited
Loading

@albertvillanova Thanks for the review. I've made the suggested changes. I have one clarification, Please take a look when you are free

@aaronjimv aaronjimv mentioned this pull request Oct 22, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aymeric-roucher aymeric-roucher aymeric-roucher approved these changes

@albertvillanova albertvillanova Awaiting requested review from albertvillanova

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suryabdev @albertvillanova @aymeric-roucher