Skip to content

O(n^m) to O(n) for finding no target names #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

O(n^m) to O(n) for finding no target names #2372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed79f06
O(n^m) to O(n) for finding no target names
AllenHW Feb 10, 2025
5dc9fdf
naming improvement
AllenHW Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/peft/tuners/tuners_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,11 +460,15 @@ def inject_adapter(
isinstance(peft_config.target_modules, (list, set))
and len(peft_config.target_modules) >= MIN_TARGET_MODULES_FOR_OPTIMIZATION
):
names_no_target = [
name
for name in key_list
if not any((name == suffix) or name.endswith("." + suffix) for suffix in peft_config.target_modules)
]
target_modules_set = set(peft_config.target_modules)
names_no_target = []
for name in key_list:
parts = name.split('.')
suffixes = ['.'.join(parts[i:]) for i in range(len(parts))]
# Check if any of the suffixes (i.e. ['a.b.c', 'b.c', 'c']) are in the target_modules_set
if not any(suffix in target_modules_set for suffix in suffixes):
names_no_target.append(name)

new_target_modules = _find_minimal_target_modules(peft_config.target_modules, names_no_target)
if len(new_target_modules) < len(peft_config.target_modules):
peft_config.target_modules = new_target_modules
Expand Down