Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformers v4.49 support #2191

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Add transformers v4.49 support #2191

merged 5 commits into from
Feb 24, 2025

Conversation

echarlaix
Copy link
Collaborator

No description provided.

@echarlaix echarlaix marked this pull request as ready for review February 21, 2025 16:51
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix
Copy link
Collaborator Author

Failing tests

onnxruntime.capi.onnxruntime_pybind11_state.NotImplemented: [ONNXRuntimeError] : 9 : NOT_IMPLEMENTED : Could not find an implementation for ArgMax(13) node with name '/ArgMax'

will be fixed in huggingface/transformers#36332

@echarlaix echarlaix merged commit f4c9021 into main Feb 24, 2025
35 of 40 checks passed
@echarlaix echarlaix deleted the transformers-449 branch February 24, 2025 10:41
@xenova
Copy link
Contributor

xenova commented Mar 4, 2025

I've tested converting LlamaForCausalLM models, but I'm running into this error:

Detailed error: Required inputs (['onnx::Gather_7']) are missing from input feed (['input_ids', 'attention_mask', 'position_ids', 'past_key_values.0.key', 'past_key_values.0.value', 'past_key_values.1.key', 'past_key_values.1.value'])..

Command:

optimum-cli export onnx -m hf-internal-testing/tiny-random-LlamaForCausalLM /tmp

I assume onnx::Gather_7 is related to logits_to_keep?

@xenova
Copy link
Contributor

xenova commented Mar 4, 2025

Ahh nevermind!! I was on an old version of Optimum 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants