-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ViTPose #2183
ViTPose #2183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ariG23498! Could you merge the commits from #2098 into this PR too so we only have one PR to review/merge? Thanks!
@xenova I have made the adjustments. Is it okay now? |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added support for exporting models with num_experts>1
and things seem to work well. I've also created a tiny-random model which can be used for testing. Other than that, LGTM ✅
cc @echarlaix for final review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot !
This PR will:
CC: @xenova
I am following this guide. While @xenova has already taken care of the configurations and registry, I am trying to push this PR to the end line.
Currently the following works
Are there any other immediate check that I need to perform?