Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash if gaudi_config is not passed to GaudiTrainer, only gaudi_c… #613

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

sywangyi
Copy link
Collaborator

…onfig_name is passed in training args.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

…onfig_name is passed in training args.

Signed-off-by: Wang, Yi A <[email protected]>
@sywangyi sywangyi requested a review from regisss as a code owner December 26, 2023 05:37
@sywangyi
Copy link
Collaborator Author

call stack like
Traceback (most recent call last):
File "/intel-extension-for-transformers/optimum-habana/examples/language-modeling/run_clm.py", line 697, in
main()
File "/intel-extension-for-transformers/optimum-habana/examples/language-modeling/run_clm.py", line 625, in main
trainer = GaudiTrainer(
File "/intel-extension-for-transformers/optimum-habana/optimum/habana/transformers/trainer.py", line 217, in init
gaudi_config.declare_autocast_bf16_fp32_ops()
AttributeError: 'NoneType' object has no attribute 'declare_autocast_bf16_fp32_ops'

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@regisss regisss merged commit 0152688 into main Dec 29, 2023
9 checks passed
@regisss regisss deleted the gaudi_config_crash branch December 29, 2023 15:24
dsocek pushed a commit to dsocek/optimum-habana that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants