-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dataset disposal of b-mc2/sql-create-context for codegen and fix zero3 lora save issue #552
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
0fb0359
to
346fcb6
Compare
b4efaa7
to
6dcd4f0
Compare
@regisss could you help review the PR, also model save is fixed, the state_dict needs "to('cpu')" before being saved, so I use save_model api instead. |
6dcd4f0
to
33d2c4c
Compare
Does it save the whole model or just the adapter weights? |
only adapter weights is saved |
@mandy-li mandy, could you help review the PR? this PR also fix same issue in model save for deepspeed zero3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@regisss could you help merge it? |
b59eb81
to
773842b
Compare
Signed-off-by: Wang, Yi A <[email protected]>
773842b
to
3119774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments to address and then I merge 🙂
Co-authored-by: regisss <[email protected]>
Co-authored-by: regisss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
Fixes # (issue)
Before submitting