Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dataset disposal of b-mc2/sql-create-context for codegen and fix zero3 lora save issue #552

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

sywangyi
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@sywangyi sywangyi requested a review from regisss as a code owner November 22, 2023 03:38
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sywangyi
Copy link
Collaborator Author

sywangyi commented Nov 30, 2023

@regisss could you help review the PR, also model save is fixed, the state_dict needs "to('cpu')" before being saved, so I use save_model api instead.

@sywangyi sywangyi force-pushed the sql-dataset-support branch from 6dcd4f0 to 33d2c4c Compare November 30, 2023 08:44
@regisss
Copy link
Collaborator

regisss commented Nov 30, 2023

@regisss could you help review the PR, also model save is fixed, the state_dict needs "to('cpu')" before being saved, so I use save_model api instead.

Does it save the whole model or just the adapter weights?

@sywangyi
Copy link
Collaborator Author

@regisss could you help review the PR, also model save is fixed, the state_dict needs "to('cpu')" before being saved, so I use save_model api instead.

Does it save the whole model or just the adapter weights?

only adapter weights is saved

@sywangyi sywangyi changed the title add dataset disposal of b-mc2/sql-create-context for codegen add dataset disposal of b-mc2/sql-create-context for codegen and fix zero3 lora save issue Nov 30, 2023
@sywangyi
Copy link
Collaborator Author

@mandy-li mandy, could you help review the PR? this PR also fix same issue in model save for deepspeed zero3

@mandy-li mandy-li self-requested a review December 1, 2023 00:01
Copy link
Collaborator

@mandy-li mandy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sywangyi
Copy link
Collaborator Author

sywangyi commented Dec 7, 2023

@regisss could you help merge it?

@sywangyi sywangyi force-pushed the sql-dataset-support branch from b59eb81 to 773842b Compare December 8, 2023 02:23
@sywangyi sywangyi force-pushed the sql-dataset-support branch from 773842b to 3119774 Compare December 8, 2023 12:36
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments to address and then I merge 🙂

examples/language-modeling/README.md Outdated Show resolved Hide resolved
examples/language-modeling/run_lora_clm.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisss regisss merged commit 4ffb9d7 into main Dec 8, 2023
@regisss regisss deleted the sql-dataset-support branch December 8, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants