Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domino #279

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Domino #279

wants to merge 16 commits into from

Conversation

xrsrke
Copy link
Member

@xrsrke xrsrke commented Feb 12, 2025

the first PR is ready for review (i split it to two PRs), some left work for the next PR

  • intra-layer overlapping (current overlapping communication within a layer), but if we do intra-layer overlapping, then we can almost totally overlapping the comm
  • create an fixed buffer to concat hidden states (1st image)
  • double check if there is cuda stream switching's overhead (4.3.1 in the 2nd image)
  • minimize kernel launch overhead (cuda graph? 4.3.2 in 2nd image)

profiling results

image image

profiling file: /fsx/phuc/temp/boom/issue2_domino_tp/nanotron/logs/profiles/_temp1_config_llama_domino/20250212-165229/ip-26-0-163-220_159222.1739379160555428025.pt.trace.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant