fix: change batch key from "image" to "images" in measure_vram.py #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects a KeyError caused by accessing batch["image"] instead of batch["images"], consistent with the batch structure used in train.py.
lusxvr
reviewed
Jul 23, 2025
| break | ||
|
|
||
| images = batch["image"].to(device) | ||
| images = batch["images"] |
Contributor
There was a problem hiding this comment.
Looks good, but we still need the .to(device) function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a KeyError in
eval/measure_vram.pywhere the code tries to access batch["image"],but the correct key is batch["images"].
Specifically, when running
eval/measure_vram.py, I encountered the following error:KeyError: 'image'
File ".../measure_vram.py", line 130, in measure_vram
images = batch["image"].to(device)
After checking
train.py, I noticed that similar code has already been updated to use:This suggests that
measure_vram.pymay not have been updated accordingly.Related Issue
No issue submitted for this simple fix.
Testing
python eval/measure_vram.pyand confirmed this error is resolved.Notes
This is a straightforward fix to unblock running the evaluation script.