Skip to content

Fixes #1023: add custom processing logic for MetricGrouping #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes #1023: add custom processing logic for MetricGrouping #1025

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e898ea1
add custom processing logic for MetricGrouping
Oct 21, 2025
09372b8
change to match linter preference
Nov 5, 2025
3eeb609
extract metrics item part to separate function to meet linter complexity
Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 32 additions & 10 deletions src/lighteval/tasks/lighteval_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

from lighteval.metrics.metrics import Metrics
from lighteval.metrics.metrics_sample import SamplingMetric
from lighteval.metrics.utils.metric_utils import Metric
from lighteval.metrics.utils.metric_utils import Metric, MetricGrouping
from lighteval.tasks.prompt_manager import FewShotSampler
from lighteval.tasks.requests import (
Doc,
Expand Down Expand Up @@ -167,15 +167,8 @@ def __str__(self, lite: bool = False):
continue
if k == "metrics":
for ix, metrics in enumerate(v):
for metric_k, metric_v in metrics.items():
if isinstance(metric_v, Callable):
repr_v = metric_v.__name__
elif isinstance(metric_v, Metric.get_allowed_types_for_metrics()):
repr_v = str(metric_v)
else:
repr_v = repr(metric_v)
values.append([f"{k} {ix}: {metric_k}", repr_v])

item_str_list = self._build_metrics_item_str_list(ix, metrics)
values.extend(item_str_list)
else:
if isinstance(v, Callable):
values.append([k, v.__name__])
Expand All @@ -186,6 +179,35 @@ def __str__(self, lite: bool = False):

return md_writer.dumps()

def _build_metrics_item_str_list(self, ix: int, metrics: dict) -> list:
values = []

is_metric_grouping = False

if isinstance(getattr(self, "metrics")[ix], MetricGrouping):
is_metric_grouping = True

for metric_k, metric_v in metrics.items():
if is_metric_grouping and isinstance(metric_v, dict):
for metric_sub_k, metric_sub_v in metric_v.items():
if isinstance(metric_sub_v, Callable):
repr_v = metric_sub_v.__name__
elif isinstance(metric_sub_v, Metric.get_allowed_types_for_metrics()):
repr_v = str(metric_sub_v)
else:
repr_v = repr(metric_sub_v)
values.append([f"metrics {ix}: {metric_k}: {metric_sub_k}", repr_v])
else:
if isinstance(metric_v, Callable):
repr_v = metric_v.__name__
elif isinstance(metric_v, Metric.get_allowed_types_for_metrics()):
repr_v = str(metric_v)
else:
repr_v = repr(metric_v)
values.append([f"metrics {ix}: {metric_k}", repr_v])

return values

def print(self, lite: bool = False):
print(str(self, lite))

Expand Down
Loading