Skip to content

option for addition parameters #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions knockknock/slack_sender.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

DATE_FORMAT = "%Y-%m-%d %H:%M:%S"

def slack_sender(webhook_url: str, channel: str, user_mentions: List[str] = []):
def slack_sender(webhook_url: str, channel: str, user_mentions: List[str] = [], host=None, infos = {}):
"""
Slack sender wrapper: execute func, send a Slack notification with the end status
(sucessfully finished or crashed) at the end. Also send a Slack notification before
Expand All @@ -35,7 +35,10 @@ def decorator_sender(func):
def wrapper_sender(*args, **kwargs):

start_time = datetime.datetime.now()
host_name = socket.gethostname()
if host is None:
host_name = socket.gethostname()
else:
host_name = str(host)
func_name = func.__name__

# Handling distributed training edge case.
Expand All @@ -54,6 +57,8 @@ def wrapper_sender(*args, **kwargs):
'Machine name: %s' % host_name,
'Main call: %s' % func_name,
'Starting date: %s' % start_time.strftime(DATE_FORMAT)]
for (key, value) in infos.items():
contents.append(key+': '+str(value))
contents.append(' '.join(user_mentions))
dump['text'] = '\n'.join(contents)
dump['icon_emoji'] = ':clapper:'
Expand All @@ -71,7 +76,8 @@ def wrapper_sender(*args, **kwargs):
'Starting date: %s' % start_time.strftime(DATE_FORMAT),
'End date: %s' % end_time.strftime(DATE_FORMAT),
'Training duration: %s' % str(elapsed_time)]

for (key, value) in infos.items():
contents.append(key+': '+str(value))
try:
str_value = str(value)
contents.append('Main call returned value: %s'% str_value)
Expand All @@ -98,6 +104,8 @@ def wrapper_sender(*args, **kwargs):
'%s\n\n' % ex,
"Traceback:",
'%s' % traceback.format_exc()]
for (key, value) in infos.items():
contents.append(key+': '+str(value))
contents.append(' '.join(user_mentions))
dump['text'] = '\n'.join(contents)
dump['icon_emoji'] = ':skull_and_crossbones:'
Expand Down