Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HfApi.list_files_info #1910

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Deprecate HfApi.list_files_info #1910

merged 8 commits into from
Dec 15, 2023

Conversation

mariosasko
Copy link
Contributor

This PR deprecates the HfApi.list_files_info method, as suggested in #1809 (review),. The usage of this method is still low (based on the GitHub/Hub code search), so this shouldn't cause any problems for the users.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@mariosasko
Copy link
Contributor Author

@Wauplin Maybe expect_deprecation (and xfail_on_windows, etc.) should be defined as a pytest marker to support "decorating" test classes, but it's probably better to address this in a separate PR.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that @mariosasko! Left two small comments but overall looks good.

Agree on switching to pytest marks instead of decorators but low priority I think (but I agree the testing suite/utils are quite disparate at the moment).

src/huggingface_hub/_commit_api.py Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
@Wauplin
Copy link
Contributor

Wauplin commented Dec 15, 2023

Thanks for making the changes @mariosasko! I'm merging it now :)

@Wauplin Wauplin merged commit 7319ea4 into main Dec 15, 2023
14 of 16 checks passed
@Wauplin Wauplin deleted the deprecate-list_files_info branch December 15, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants