-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate HfApi.list_files_info
#1910
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@Wauplin Maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on that @mariosasko! Left two small comments but overall looks good.
Agree on switching to pytest marks instead of decorators but low priority I think (but I agree the testing suite/utils are quite disparate at the moment).
Co-authored-by: Lucain <[email protected]>
Thanks for making the changes @mariosasko! I'm merging it now :) |
This PR deprecates the
HfApi.list_files_info
method, as suggested in #1809 (review),. The usage of this method is still low (based on the GitHub/Hub code search), so this shouldn't cause any problems for the users.