[inference] Partial revert of #1199, cleaner implem #1201
Merged
+123
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
requested review from
hanouticelina,
SBrandeis and
coyotte508
as code owners
julien-c
commented
Feb 13, 2025
| @@ -243,6 +243,10 @@ function makeUrl(params: { | |||
| } | |||
| default: { | |||
| const baseUrl = HF_HUB_INFERENCE_PROXY_TEMPLATE.replaceAll("{{PROVIDER}}", "hf-inference"); | |||
| if (params.taskHint && ["feature-extraction", "sentence-similarity"].includes(params.taskHint)) { | |||
| /// when deployed on hf-inference, those two tasks are automatically compatible with one another. | |||
| return `${baseUrl}/pipeline/${params.taskHint}/${params.model}`; | |||
There was a problem hiding this comment.
would be cleaner if it was /{model}/pipeline/{task}, probably (also simpler to route)
coyotte508
approved these changes
Feb 14, 2025
Wauplin
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Let's do that 😄 I made the same PR for huggingface_hub: huggingface/huggingface_hub#2861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.