-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: add hyperbolic support #1191
draft: add hyperbolic support #1191
Conversation
c507b1e
to
33771e6
Compare
Thanks @Kaihuang724! i've rebased on top of main as we changed things a bit in the past few days. Let me know if my commits make sense. As you pointed out the Hyperbolic, 2 out of 4 tests currently don't pass. I haven't checked why yet, but here's how you can run just the Hyperbolic tests locally (from inside pnpm test -- -t "Hyperbolic" When they do pass you can record the VCR tapes (so the CI doesn't run actual requests): VCR_MODE=record pnpm test -- -t "Hyperbolic" Will help early next week if you're stuck |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
"meta-llama/Llama-3.2-3B-Instruct": "meta-llama/Llama-3.2-3B-Instruct", | ||
"meta-llama/Llama-3.3-70B-Instruct": "meta-llama/Llama-3.3-70B-Instruct", | ||
"stabilityai/stable-diffusion-2": "stabilityai/stable-diffusion-2", | ||
"meta-llama/Llama-3.1-405B-BASE-FP8": "meta-llama/Llama-3.1-405B-BASE-FP8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the keys should be HF model ids (it's not the case for the last one at least)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Kaihuang724 !
Would you mind updating the VCR tapes (=pre-cached API responses for online testing), please?
We need them for the CI tests.
You can do so by running the following command:
VCR_MODE=cache pnpm run test
@Kaihuang724 let us know if any help is needed! |
I went ahead and updated the VCR tapes, but I still can't get the tests to run successfully. I'm not sure why, it seems like it's trying to call our API with this model: |
It seems that your chat completion API default to the mistral model when no model is provided in the body - is that correct? Note that we only add the Make sure the URL and body outputed by If not you will have to implement an adapter in the associated task method, eg here for text-to-image: |
Thank you @SBrandeis ! This PR should be ready for review now. |
Hi @connorch - thank you for your changes!
But most importantly de26ffa : huggingface.js/packages/inference/test/HfInference.spec.ts Lines 1180 to 1257 in de26ffa
I updated the tests to match our types and expected APIs, which revealed there is the need to implement adapters to transform inputs and outputs for the Namely:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this over the finish line, @SBrandeis <3
Thank you @SBrandeis ! I appreciate you cleaning things up and getting this merged 🙌 |
Added Hyperbolic as an inference provider