Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bot] Update tasks specs #1178

Closed
wants to merge 1 commit into from

Conversation

HuggingFaceInfra
Copy link
Contributor

This PR updates the @huggingface/tasks specs. It has been generated by running:

pnpm run inference-tgi-import
pnpm run inference-tei-import
pnpm run inference-codegen

This PR was automatically created by the Tasks - Update specs workflow.

Make sure the changes are correct before merging.

@Wauplin
Copy link
Contributor

Wauplin commented Feb 5, 2025

I don't get why it's reverting this 😕

@HuggingFaceInfra HuggingFaceInfra force-pushed the update-tasks-specs-automated-pr branch from 1e8efea to acf9eb1 Compare February 5, 2025 11:37
@hanouticelina
Copy link
Contributor

@Wauplin I think it's because of the inference-tei-import script here that overrides the feature-extraction schema with the TEI schema.

@Wauplin
Copy link
Contributor

Wauplin commented Feb 5, 2025

Ah yes ofc, thanks for finding out. I'll figure out what I can do to fix this

Wauplin added a commit that referenced this pull request Feb 5, 2025
Related to #1166 (and
see
#1178).

In #1166, I've made
possible to pass either a `string` or `string[]` as `feature-extraction`
input. But since this schema is based on TEI via the
`inference-tei-import` script, we also need to update it which this PR
does.

**Expectation:** exact same specs but this time we won't have a PR like
https://github.com/huggingface/huggingface.js/pull/1178/files opened.
@HuggingFaceInfra HuggingFaceInfra force-pushed the update-tasks-specs-automated-pr branch from acf9eb1 to 499c9a7 Compare February 5, 2025 14:56
@Wauplin
Copy link
Contributor

Wauplin commented Feb 5, 2025

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specs tasks @huggingface/tasks related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants