feat(ci): ignore unverified trufflehog results #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
approved these changes
Feb 4, 2025
|
@McPatate is it fine / safe if I open the same PR on huggingface_hub side ? |
|
@Wauplin sure go ahead! |
|
Opened huggingface/huggingface_hub#2837 :) |
nsarrazin
added a commit
to huggingface/chat-ui
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had a lot of false positives for unverified trufflehog results, causing the CI pipeline to fail.
I had left them intentionally as they were infrequent at first, but given their recent increase in frequency, I feel it's safe to only check for verified secrets.