[ControlnetUnion] Multiple Fixes #11888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyixuxu
reviewed
Jul 9, 2025
| @@ -240,8 +247,8 @@ def __init__( | |||
| ): | |||
| super().__init__() | |||
|
|
|||
| if not isinstance(controlnet, ControlNetUnionModel): | |||
| raise ValueError("Expected `controlnet` to be of type `ControlNetUnionModel`.") | |||
| if isinstance(controlnet, (list, tuple)): | |||
There was a problem hiding this comment.
ohh, so you would need to use multiple models too for controlnet union?
There was a problem hiding this comment.
yeah this was added in this PR because of this comment
Basically is for people that want to control the start and the end for each condition, if you don't need that, you can use one controlnet union with multiple conditions.
Also is to make it the same as other controlnets so people don't have to code a special case for just this one in the UIs.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
tolgacangoz
pushed a commit
to tolgacangoz/diffusers
that referenced
this pull request
Jul 17, 2025
fixes --------- Co-authored-by: hlky <[email protected]>
tolgacangoz
pushed a commit
to tolgacangoz/diffusers
that referenced
this pull request
Jul 17, 2025
tolgacangoz
pushed a commit
to tolgacangoz/diffusers
that referenced
this pull request
Jul 18, 2025
fixes --------- Co-authored-by: hlky <[email protected]>
tolgacangoz
pushed a commit
to tolgacangoz/diffusers
that referenced
this pull request
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the problems in the related issues, also it surprises me that no one have ever used this controlnet without cfg because it doesn't work, this PR also fixes that.
fixes #11861 #11828
Who can review?
@yiyixuxu