Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lumina2 refactor #10732

Closed
wants to merge 16 commits into from
Closed

Lumina2 refactor #10732

wants to merge 16 commits into from

Conversation

a-r-r-o-w
Copy link
Member

@a-r-r-o-w a-r-r-o-w commented Feb 6, 2025 •
edited
Loading

Hi @zhuole1025. I've refactored the Lumina2 implementation and believe this should be good to get us ready for reviews by @yiyixuxu, and be able to merge soon. If the changes look good to you, either:

  • you could cherry pick these commits into your branch
  • have me directly push the same changes to your branch in Add support for lumina2 #10642 or open a PR to it

These are the only relevant changes from my end:

image

LMK what works best for you 🤗

@a-r-r-o-w a-r-r-o-w mentioned this pull request Feb 6, 2025
Merged
@zhuole1025
Copy link
Contributor

@a-r-r-o-w Thanks for your efforts in making these improvements! I have checked them and very glad that you can directly push into the lumina2 pr~

@a-r-r-o-w a-r-r-o-w closed this Feb 7, 2025
@a-r-r-o-w a-r-r-o-w deleted the lumina2-refactor branch February 7, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-r-r-o-w @zhuole1025 @csuhan