Skip to content

Fix a dtype issue when evaluating the sana transformer with a float16 autocast context #10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nerogar
Copy link
Contributor

@Nerogar Nerogar commented Dec 23, 2024

What does this PR do?

the query, key and value tensors of the attention calculations are already converted to float32 format. But if an autocast context is active, intermediate values are still converted back to float16 precision. Disabling autocast in this region prevents this unwanted conversion. The result is then converted back to the original dtype afterwards.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@lawrence-cj

@bghira
Copy link
Contributor

bghira commented Jan 3, 2025

this probably will cause a torch compile graph break since it's inline in a compiled function. (upstream issue here)

@Nerogar Nerogar force-pushed the allow_sana_mixed_precision branch from 900cf7d to 3d013a8 Compare January 21, 2025 18:29
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Feb 15, 2025
@Nerogar
Copy link
Contributor Author

Nerogar commented Feb 15, 2025

Bad bot. This is not an issue, it's a pull request that should be merged once the upstream issue in PyTorch is fixed.

@a-r-r-o-w a-r-r-o-w added wip and removed stale Issues that haven't received updates labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants