Test timesteps in PipelineTesterMixin
#10113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. But I think we would have to adjust based on the scheduler (think you mentioned this already in #10101) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Companion to #10101. Adds
test_timestepstoPipelineTesterMixin, some pipelines already testtimesteps, useful to test all of them, for example this could have caught #10080 by raising thattimestepsisn't supported by the scheduler then it might have been noticed thatsigmaswas unsupported in the pipeline.As expected this test reveals pipelines that are not working with
timestepsargument. This PR is created so everyone can refer to test results for the list of affected pipelines, as such this PR should not be merged in its current state, we will investigate each pipeline to determine the appropriate course of action (removing the unsupported argument, fixing an error, etc.)Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.