Skip to content

Conversation

xhaktm00
Copy link
Contributor

@xhaktm00 xhaktm00 commented Aug 26, 2025

What does this PR do?

Translated the what is function calling.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of huggingface/transformers#20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?
-- @harheem, @nsbg, @Youngdong2, @xhaktm00, @Judy-Choi

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@sergiopanieg May you please review this PR?

Copy link
Contributor

@harheem harheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함수 호출! 중요하고 좋은 문서네요. 번역해주셔서 감사합니다. 아래와 같은 점을 고려하면서 수정 사항을 남겨보았으니 확인해보시고, 의견 남겨주세요. 🤗

  • Think, Action, Observation은 쉬운 단어이긴 하나, 한국어로도 같이 정리되었으면 하여 '사고, 행동, 관찰'을 추가하였습니다.
  • 한국어로 사용할 수 있는 부분믄 한국어를 살려보았습니다. (ex. 포맷합니다 -> 출력합니다)
  • 한국어 사용자들이 조금 더 이해하기 쉽도록 연결어나 맥락 정보를 추가하여 다듬어보았습니다.

@xhaktm00
Copy link
Contributor Author

@harheem 수정되어야 할 이유와 함께 리뷰 남겨주셔서 감사합니다☺️ 덕분에 문서가 더 이해하기 쉽도록 잘 번역된 것 같습니다.
남겨주신 수정 사항 반영하였습니다. 확인 부탁드립니다.

@harheem
Copy link
Contributor

harheem commented Oct 14, 2025

빠른 반영 감사합니다아- 혹시 17번, 34번 라인만 추가로 더 반영 부탁드려도될까요?? @xhaktm00

@xhaktm00
Copy link
Contributor Author

@harheem 반영 완료했습니다!

Copy link
Contributor

@harheem harheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😍

@xhaktm00 xhaktm00 marked this pull request as ready for review October 14, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants