[tests] Fix bnb cpu error #3351
Open
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
reviewed
Feb 5, 2025
Comment on lines
+1474
to
+1478
| if ( | ||
| ("cpu" in model_devices and not is_bitsandbytes_multi_backend_available()) | ||
| or ("cpu" in model_devices and is_xpu_available()) | ||
| or "disk" in model_devices | ||
| ): |
There was a problem hiding this comment.
does this mean that with xpu, it doesn't work if the model in on cpu even if bnb multi-backend is installed ?
There was a problem hiding this comment.
yes, cpu and xpu share the same bnb installation method, namely the multi-backend support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up on PR #3350.
The reason for the failure is that
is_bitsandbytes_multi_backend_available()returns True on XPU, but False on CUDA. And this is because CUDA and XPU have different ways to install bitsandbytes (see here).To align the behavior on CUDA and XPU, we need to add an XPU check, thus this PR.
cc @muellerzr @SunMarc