Torchao float8 training #3348
Open
Torchao float8 training #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuzo
reviewed
Jan 16, 2025
benchmarks/fp8/torchao/ddp.py
Outdated
| old_named_params = get_named_parameters(model) | ||
|
|
||
| with torch.no_grad(): | ||
| convert_model(model) |
There was a problem hiding this comment.
looks like this is still using TE - intended?
There was a problem hiding this comment.
Nope, needed to update these scripts, thought I had only pushed single-GPU! Though now DDP and FSDP are good, verifying DeepSpeed in a moment
vkuzo
reviewed
Jan 16, 2025
vkuzo
reviewed
Jan 16, 2025
muellerzr
force-pushed
the
torchao-float8
branch
from
f805876 to
92b3d9b
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is the start of incorporating torchao float8 training into Accelerate.
It does so by refactoring the backend to be more modular as more FP8 backends come out, and adds new benchmarking tests for it.
Current status of benchmarks:
Also need to work on a testing suite.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc