Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨🚨🚨 The Great Deprecation 🚨🚨🚨 #3098

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

This PR applies all deprecations for 1.0.0:

  • Users now must make a DataLoaderConfiguration to set items like even_batches, use_seedable_sampler, etc
  • use_fp16 properties are now gone
  • Accelerator.autocast no longer accepts a cache_enabled arg, users must make an AutocastKwargs instance and pass it in as a kwarg handler
  • fsdp_backward_prefetch_policy is replaced with fsdp_backward_prefetch
  • AcceleratedOptimizer.is_overflow should be replaced with AcceleratedOptimizer.step_was_skipped
  • is_tpu_available should be replaced with is_torch_xla_available
  • ACCELERATE_DISABLE_RICH is no longer a valid env variable, one should manually enable rich traceback via ACCELERATE_ENABLE_RICH
  • utils.modeling.shard_checkpoint should be replaced with split_torch_state_dict_into_shards from the huggingface_hub library
  • accelerate's tqdm wrapper no longer takes True/False as the first argument, one should manually pass in main_process_only as a kwarg instead

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan
@SunMarc

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+4 −247

🤩

Looks good, thanks for addressing these (sometimes long overdue) deprecations.

I also did a check on the code base to see if anything was missing and found these potential candidates, WDYT?

  1. # TODO: at the next Transformers release (4.28.0) issue a deprecation warning here.
  2. https://github.com/huggingface/accelerate/blob/main/src/accelerate/memory_utils.py
  3. - **TPU** -- This field will be deprecated in v0.27.0. Use XLA instead.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of that @muellerzr ! LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants