Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall DVC in the Trainer tests #2271

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Uninstall DVC in the Trainer tests #2271

merged 2 commits into from
Dec 22, 2023

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Autopicking up DVC in the env leads to very annoying DVC issues related to git configs for the trainer specifically. Since these tests are already ran nightly on the trainer side this PR just disables them in Accelerate locally by uninstalling yet another problematic tracker during tests.

Fixes # (issue)

The failing tests on main.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc

@muellerzr muellerzr requested a review from SunMarc December 21, 2023 17:31
@muellerzr
Copy link
Collaborator Author

Job to verify everything is working being ran here: Integration Tests (push to "main")

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests !

@muellerzr muellerzr merged commit 349be97 into main Dec 22, 2023
28 checks passed
@muellerzr muellerzr deleted the test-cli branch December 22, 2023 13:04
ji-huazhong pushed a commit to ji-huazhong/accelerate that referenced this pull request Jan 22, 2024
* Test using my branch

* Uninstall DVCLive only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants